add ExtractedSubquery to the precedence logic

Signed-off-by: Andres Taylor <andres@planetscale.com>

go/vt/sqlparser/precedence.go

@@ -90,6 +90,8 @@ func precedenceFor(in Expr) Precendence {
 		}
 	case *IntervalExpr:
 		return P1
+	case *ExtractedSubquery:
+		return precedenceFor(node.Original)
 	}
 
 	return Syntactic

go/vt/sqlparser/precedence_test.go

@@ -21,6 +21,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -65,6 +66,28 @@ func TestAndOrPrecedence(t *testing.T) {
 	}
 }
 
+func TestNotInSubqueryPrecedence(t *testing.T) {
+	tree, err := Parse("select * from a where not id in (select 42)")
+	require.NoError(t, err)
+	not := tree.(*Select).Where.Expr.(*NotExpr)
+	cmp := not.Expr.(*ComparisonExpr)
+	subq := cmp.Right.(*Subquery)
+	fmt.Println(subq)
+
+	extracted := &ExtractedSubquery{
+		Original:     cmp,
+		ArgName:      "arg1",
+		HasValuesArg: "has_values1",
+		OpCode:       1,
+		Subquery:     subq.Select,
+		OtherSide:    cmp.Left,
+	}
+	not.Expr = extracted
+
+	output := readable(not)
+	assert.Equal(t, "not (:has_values1 = 1 and id in ::arg1)", output)
+}
+
 func TestPlusStarPrecedence(t *testing.T) {
 	validSQL := []struct {
 		input  string

go/vt/sqlparser/tracked_buffer.go

@@ -169,7 +169,7 @@ func (buf *TrackedBuffer) formatter(node SQLNode) {
 	}
 }
 
-//needParens says if we need a parenthesis
+// needParens says if we need a parenthesis
 // op is the operator we are printing
 // val is the value we are checking if we need parens around or not
 // left let's us know if the value is on the lhs or rhs of the operator