Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PHP client. #3230

Closed
michael-berlin opened this issue Sep 22, 2017 · 5 comments
Closed

Drop PHP client. #3230

michael-berlin opened this issue Sep 22, 2017 · 5 comments
Assignees
@michael-berlin
Labels
Type: Feature
Milestone
v3.0

Comments

@michael-berlin
Copy link
Contributor

Since we fully support the MySQL server protocol now, we plan to remove the PHP client from the code base.

The test for it is currently broken anyway. That's because we picked up regressions after we disabled it on Travis when the test no longer worked with gRPC 1.0.

Advantages of this decision:

  • One thing less to maintain.
  • Less build dependencies.
  • Faster Docker image builds because PHP compiles the gRPC C library itself.
@michael-berlin michael-berlin self-assigned this Sep 22, 2017
@sougou
Copy link
Contributor

sougou commented Sep 22, 2017

@rnavarro @jrossiter

@Rastusik
Copy link
Contributor

finally! 👍 :)

@enisoc
Copy link
Member

enisoc commented Sep 22, 2017

This makes me sad, but also happy.

@ronlobo
Copy link

ronlobo commented Sep 22, 2017

PHP AF

@michael-berlin michael-berlin mentioned this issue Oct 4, 2017
Closed
@rnavarro
Copy link
Contributor

I have seeded this notion internally and it's on everyone's radar. We're going to look at effort required to get this done so we can port over.

YAY

@sougou sougou added this to the v3.0 milestone Nov 26, 2017
sougou added a commit to sougou/vitess that referenced this issue Dec 6, 2017
@sougou
php: drop php client
7de8ffd 
Issue vitessio#3230
Now that we support mysql protocol, there's no need to support
a custom PHP client any more.
@sougou sougou mentioned this issue Dec 6, 2017
Merged
@sougou sougou closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-berlin michael-berlin

Labels
Type: Feature
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
6 participants
@rnavarro @ronlobo @sougou @Rastusik @michael-berlin @enisoc