Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix races in memory topo and watcher #11065

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fix races in memory topo and watcher #11065

merged 1 commit into from
Aug 23, 2022

Conversation

dbussink
Copy link
Contributor

We should only setup the goroutine after we've grabbed the lock to safely start the watcher.

Additionally, the watcher should only be retried if we're not interrupted and shutting down for example.

Related Issue(s)

Follow up fixes after changes in #10954 & #10906

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 22, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink dbussink requested a review from vmg August 22, 2022 12:27
@dbussink
Fix races in memory topo and watcher
7b99263 
We should only setup the goroutine after we've grabbed the lock to
safely start the watcher.

Additionally, the watcher should only be retried if we're not
interrupted and shutting down for example.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/fix-races-in-memory-topo branch from ca063c4 to 7b99263 Compare August 22, 2022 13:01
@vmg vmg merged commit 3d376ea into vitessio:main Aug 23, 2022
@vmg vmg deleted the dbussink/fix-races-in-memory-topo branch August 23, 2022 07:25
@dbussink dbussink mentioned this pull request Aug 29, 2022
Merged
3 tasks
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Sep 21, 2022
@dbussink
Fix races in memory topo and watcher (vitessio#11065) (vitessio#995)
6bc0171 
We should only setup the goroutine after we've grabbed the lock to
safely start the watcher.

Additionally, the watcher should only be retried if we're not
interrupted and shutting down for example.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Sep 21, 2022
@mattlord
Revert WatchRecursive Topo Feature (vitessio#1023)
ba735af 
* Revert "Add explicit close state to memory topo connection (vitessio#11110) (vitessio#1016)"

This reverts commit eb1e9c2.

* Revert "Fix races in memory topo and watcher (vitessio#11065) (vitessio#995)"

This reverts commit 6bc0171.

* Revert "Avoid race condition in watch shutdown (vitessio#10954) (vitessio#936)"

This reverts commit 23d4e34.

* Revert "Remove potential double close of channel (vitessio#10929) (vitessio#921)"

This reverts commit 0121e5d.

* Revert "Cherry pick topo improvements (vitessio#10906) (vitessio#916)"

This reverts commit 8c9f56d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmg vmg vmg approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rafael rafael Awaiting requested review from rafael

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbussink @vmg