Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vtorc tests to run as a single test with sub-tests #11108

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Refactor vtorc tests to run as a single test with sub-tests #11108

merged 1 commit into from
Aug 30, 2022

Conversation

GuptaManan100
Copy link
Member

Description

This PR refactors some VTOrc tests to run as a single test with sub-tests. The time of execution is brought down from 6 minutes 34 seconds to 5 minutes 5 seconds.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
refactor: refactor vtorc tests to run as a single test with sub-tests
3082f5d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 28, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@rsajwani
Copy link
Contributor

LGTM

@GuptaManan100 GuptaManan100 merged commit 6fd7050 into vitessio:main Aug 30, 2022
@GuptaManan100 GuptaManan100 deleted the vtorc-test-merge branch August 30, 2022 11:26
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Oct 11, 2023
@GuptaManan100 @timvaillancourt
refactor: refactor vtorc tests to run as a single test with sub-tests (…
e7fee16 
…vitessio#11108)

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Oct 13, 2023
@timvaillancourt @GuptaManan100 @rohit-nayak-ps
slack-vitess-r14.0.5: backport vitessio#13723 (#142)
51c1507 
* refactor: refactor vtorc tests to run as a single test with sub-tests (vitessio#11108)

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

* `vtctld`/`vtorc`: improve reparenting stats (vitessio#13723)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

* revert changes to go/test/endtoend

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* remove unrelated+incompatible test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix memorytopo.NewServer(...) for v14

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* remove non-existant "PrimaryStatusResults" field

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Remove FOSSA Test from CI until we can do it in a secure way (vitessio#14119)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Rohit Nayak <57520317+rohit-nayak-ps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsajwani rsajwani rsajwani approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuptaManan100 @rsajwani