Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema RPC to fetch table/view definition #12375

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Schema RPC to fetch table/view definition #12375

merged 7 commits into from
Feb 21, 2023

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 15, 2023 •
edited
Loading

Description

This PR adds a new RPC to the vttablet query service for VTGate to invoke to retrieve the updated view or table definition.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal
feat: proto changes to add new rpc
518ab72 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: vttablet changes in queryservice to implement the new rpc
d001e05 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving Forwardport to: main This will forward port the PR to the main branch Skip CI Skip CI actions from running labels Feb 15, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 15, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 15, 2023 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 15, 2023
@frouioui frouioui mentioned this pull request Feb 16, 2023
Closed
51 tasks
@harshit-gangal harshit-gangal mentioned this pull request Feb 16, 2023
Closed
16 tasks
@harshit-gangal
added test on tabletserver
0a53ec1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
deepthi reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment in schema.go needs to be updated

// This file provides a few utility variables and methods, mostly for tests.
// The assumptions made about the types of fields and data returned
// by MySQl are validated in schema_test.go. This way all tests
// can use these variables and methods to simulate a MySQL server
// (using fakesqldb/ package for instance) and still be guaranteed correct
// data.

We are now using those queries in production, not just tests.

go/vt/vttablet/tabletserver/query_executor.go Outdated Show resolved Hide resolved
go/vt/vttablet/tabletserver/query_executor.go Outdated Show resolved Hide resolved
proto/query.proto Outdated Show resolved Hide resolved
@harshit-gangal
feat: use the new schema rpc in vtgate to get updated view definition
c93e57c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed the Skip CI Skip CI actions from running label Feb 16, 2023
@harshit-gangal
remove error from getschemaresponse and change the enum name
e8e0ba6 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
updated proto files for vtadmin
1394dca 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal marked this pull request as ready for review February 16, 2023 21:15
@harshit-gangal
fix e2e test
2bd3777 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
frouioui
frouioui reviewed Feb 17, 2023
View reviewed changes
go/vt/vtgate/schema/tracker.go Show resolved Hide resolved
go/vt/vttablet/endtoend/views_test.go
&vtrpcpb.CallerID{},
&querypb.VTGateCallerID{Username: "dev"}))

defer client.Execute(qDelAllRows, nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shoudn't we do this after client.Execute and before the require.NoError

@frouioui frouioui merged commit 30f8294 into vitessio:release-16.0 Feb 21, 2023
@frouioui frouioui deleted the schema-rpc branch February 21, 2023 07:32
@vitess-bot vitess-bot bot mentioned this pull request Feb 21, 2023
Merged
harshit-gangal added a commit that referenced this pull request Feb 21, 2023
@vitess-bot @harshit-gangal
[main] Schema RPC to fetch table/view definition (#12375) (#12397)
1f60c7b 
* feat: proto changes to add new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: vttablet changes in queryservice to implement the new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* added test on tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: use the new schema rpc in vtgate to get updated view definition

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* remove error from getschemaresponse and change the enum name

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* updated proto files for vtadmin

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix e2e test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Forwardport to: main This will forward port the PR to the main branch Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshit-gangal @deepthi @frouioui @GuptaManan100