Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade release-16.0 to go1.20.1 #12398

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Upgrade release-16.0 to go1.20.1 #12398

merged 8 commits into from
Feb 27, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 21, 2023 •
edited
Loading

Description

This PR bumps the golang version used by release-16.0 from go1.19.4 to go1.20.1. The bootstrap version goes from 14 to 14.1.

The reason for this upgrade so close to the GA release of v16 is that go1.20.1 is patching several vulnerabilities that were found in release-16.0.

It also cherry-picks #12315 to fix the x509 deprecations.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Upgrade release-16.0 to go1.19.6
e816bd1 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base go labels Feb 21, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2023 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 21, 2023
@frouioui frouioui added the Skip CI Skip CI actions from running label Feb 21, 2023
@frouioui frouioui mentioned this pull request Feb 21, 2023
Closed
51 tasks
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 21, 2023
@frouioui frouioui removed the Skip CI Skip CI actions from running label Feb 22, 2023
@frouioui frouioui changed the title Upgrade release-16.0 to go1.19.6 Upgrade release-16.0 to go1.20.1 Feb 22, 2023
@frouioui
upgrade to 1.20.1
8351506 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added the Benchmark me Add label to PR to run benchmarks label Feb 22, 2023
@frouioui
bump the golangci-lint version
63fdd4f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Apply linter suggestions
d44d84e 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Apply linter suggestions
b8d994c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-to-go1.19.6-on-16 branch from fe645f6 to b8d994c Compare February 24, 2023 10:37
frouioui and others added 3 commits February 24, 2023 15:36
@frouioui
fix TestTLSClientVerifyIdentity
90ed22f 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@dbussink @frouioui
Switch to using new Go 1.19 CRL parser (vitessio#12315)
add5eb5 
`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Skip TestFuzz for now
42adbd1 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit aa377fb into vitessio:release-16.0 Feb 27, 2023
@frouioui frouioui deleted the upgrade-to-go1.19.6-on-16 branch February 27, 2023 12:51
@deepthi deepthi restored the upgrade-to-go1.19.6-on-16 branch February 27, 2023 23:19
@deepthi deepthi mentioned this pull request Feb 28, 2023
Merged
3 tasks
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Sep 12, 2023
@frouioui @dbussink @timvaillancourt
Upgrade release-16.0 to go1.20.1 (vitessio#12398)
e364dc9 
* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
@timvaillancourt timvaillancourt mentioned this pull request Sep 12, 2023
Closed
4 tasks
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
@frouioui @dbussink @timvaillancourt
Upgrade release-16.0 to go1.20.1 (vitessio#12398)
b13b348 
* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
@timvaillancourt timvaillancourt mentioned this pull request Mar 15, 2024
Merged
4 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
@timvaillancourt @dbussink
@systay @frouioui
slack-vitess-r15.0.5: use go1.20.14 (#255)
3548975 
* go1.20.14

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* more go-version: updates

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* make proto w/go1.20

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix the golangci-lint config (vitessio#11812)

There's a bunch of deprecated linters that don't work anymore, so let's
remove them:

```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

* update golangci-lint to 1.50.1 (vitessio#11873)

Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add timeout to golangci-lint and bump its version (vitessio#12852) (vitessio#12853)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Upgrade `release-16.0` to `go1.20.1` (vitessio#12398)

* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* Remove recent golangci-lint version bump (vitessio#12909)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix conflict resolution

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* make ensure_bootstrap_version

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* hardcode previous release

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add comment for hardcoded previous release

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@timvaillancourt timvaillancourt mentioned this pull request Mar 15, 2024
Merged
4 tasks
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani rsajwani is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @dbussink @GuptaManan100