-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Add UUID functions #13097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Evalengine
changes to the evaluation engine
labels
May 16, 2023
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
May 16, 2023 19:43
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 16, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
May 16, 2023
This adds `BIN_TO_UUID`, `IS_UUID`, `UUID` & `UUID_TO_BIN`. This doesn't implement `UUID_SHORT` though since that has specific requirements to use the `server_id` which is not something that conceptually makes sense for `vtgate` since it works across different backend MySQL servers. So we avoid adding that here since there's no clear path for how to implement that. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
vmg
approved these changes
May 17, 2023
frouioui
approved these changes
May 17, 2023
4 tasks
dbussink
added a commit
to dbussink/vitess
that referenced
this pull request
Sep 21, 2023
This was missed when this was added in vitessio#13097, since the UUID() function needs to be evaluated each time and not cached. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Evalengine
changes to the evaluation engine
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
BIN_TO_UUID
,IS_UUID
,UUID
&UUID_TO_BIN
. This doesn't implementUUID_SHORT
though since that has specific requirements to use theserver_id
which is not something that conceptually makes sense forvtgate
since it works across different backend MySQL servers.So we avoid adding that here since there's no clear path for how to implement that.
Related Issue(s)
Part of #9647
Checklist