Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tablet throttler: throttled app configuration via vtctl UpdateThrottlerConfig #13351

Merged
merged 22 commits into from
Jul 13, 2023
Merged

Tablet throttler: throttled app configuration via vtctl UpdateThrottlerConfig #13351

merged 22 commits into from
Jul 13, 2023

Commits on Jun 20, 2023

  1. Adding ThrottledAppRule in ThrottlerConfig and in UpdateThrottlerConf… 

    …igRequest

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    66d2c0d View commit details
    Browse the repository at this point in the history

  2. support new throttle-app* flags in vtctl and vtctldclient commands 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d5b04e0 View commit details
    Browse the repository at this point in the history

  3. refactor ThrottleApp into throttler package 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8290c6b View commit details
    Browse the repository at this point in the history

  4. fix excessive flag 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f127649 View commit details
    Browse the repository at this point in the history

  5. WaitForThrottledApp 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3684635 View commit details
    Browse the repository at this point in the history

  6. give realistic throttler config 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6010db7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge remote-tracking branch 'upstream/main' into tablet-throttler-th… 

    …rottle-app-topo

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    dbed3bf View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Only WatchSrvKeyspace once the SrvKeyspace entry is confirmed to exist 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1a20570 View commit details
    Browse the repository at this point in the history

  2. WaitForSrvKeyspace before updating the keyspace 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    8a3256f View commit details
    Browse the repository at this point in the history

  3. only WatchSrvKeyspace _once_ 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    332569d View commit details
    Browse the repository at this point in the history

  4. adapt test, since we can't use topo-based throttling to throttle a si… 

    …ngle shard

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    18c16d6 View commit details
    Browse the repository at this point in the history

  5. fix test migration status expectation 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a37ec02 View commit details
    Browse the repository at this point in the history

  6. code comment 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    22be670 View commit details
    Browse the repository at this point in the history

  7. update flag docs 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    de54ced View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    903dfde View commit details
    Browse the repository at this point in the history

  2. import package name 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    dfde7dd View commit details
    Browse the repository at this point in the history

  3. typo 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    7df25f1 View commit details
    Browse the repository at this point in the history

  4. noCustomQuery 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    79dc0dd View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. add 'vreplication' name to all vreplication-related throttled apps 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b0d1180 View commit details
    Browse the repository at this point in the history

  2. undo last commit 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0df77d7 View commit details
    Browse the repository at this point in the history

  3. vcopier identifies as 'vcopier:vreplication...' and vplayer identifie… 

    …s as 'vplayer:vreplication...'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b795070 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. resolved conflict 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d375287 View commit details
    Browse the repository at this point in the history