Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick all pending PRs into release-17.0 #13364

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Cherry-pick all pending PRs into release-17.0 #13364

merged 7 commits into from
Jun 23, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jun 23, 2023 •
edited
Loading

Description

This PR aggregates all pending backport PRs and cherry-picks them all. We current cannot merge the vitess-bot PRs due to a GH bug. In order to unblock the release team for v17.0.0 this PR cherry-picks all that's needed.

⚠️ ⚠️ ⚠️

In order to keep track of the history - Please do not Squash Merge this PR.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 23, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Jun 23, 2023
@frouioui frouioui added Type: Internal Cleanup Backport This is a backport Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jun 23, 2023
frouioui and others added 7 commits June 23, 2023 12:36
@frouioui
Set the number of threads for release notes generation with a flag (v…
7cfda82 
…itessio#13273)

* Set the number of threads for release notes generation by a flag

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add the flag to the release instructions and remove the make commande for release notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@dbussink @frouioui
mysqlctl: Correctly encode database and table names (vitessio#13312)
576f2ae 
These need to be escaped as SQL strings for queries against the
`information_schema` or otherwise any names that need quotes will break.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@arvind-murty @frouioui
Bug fix: SQL queries erroring with message `unknown aggregation rando…
e2b9830 
…m` (vitessio#13330)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay @frouioui
bugfixes: collection of fixes to bugs found while fuzzing (vitessio#1…
e874172 
…3332)

* bugfix: left join predicate only depending on RHS turns into inner join

Signed-off-by: Andres Taylor <andres@planetscale.com>

* bugfix: use the incoming type fields to calculate the outgoing types

Signed-off-by: Andres Taylor <andres@planetscale.com>

* bugfix: filter was using wrong method on evalengine

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay @frouioui
bug: don't always wrap aggregation in coalesce (vitessio#13348)
5b4f416 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
update link for reparenting guide (vitessio#13350)
44dcb9f 
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@rohit-nayak-ps @deepthi @frouioui
Add RestorePosition and RestoredBackupTime as metrics to vttablet (vi…
1257833 
…tessio#13339)

* Add BackupPosition and BackupTime as metrics to vttablet

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* add to release notes

Signed-off-by: deepthi <deepthi@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the cherry-pick-backport-on-release-17.0 branch from 5addb03 to 1257833 Compare June 23, 2023 10:36
@frouioui frouioui mentioned this pull request Jun 23, 2023
Closed
This was referenced Jun 23, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@mattlord mattlord merged commit 63da486 into vitessio:release-17.0 Jun 23, 2023
@mattlord mattlord deleted the cherry-pick-backport-on-release-17.0 branch June 23, 2023 13:15
ajm188
ajm188 reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have one concern but otherwise fine

go/tools/release-notes/release_notes.go
pflag.Parse()

log.Println(numberOfThreads)
os.Exit(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajm188 correct! the release team and I saw that. I'll fix it on release-17.0 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 left review comments

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@frouioui @mattlord @ajm188 @harshit-gangal @dbussink @arvind-murty @systay @rohit-nayak-ps