Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttler: verify deprecated flags are still allowed #13615

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Throttler: verify deprecated flags are still allowed #13615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
647c08c
Throttler: verify deprecated flags are still allowed
shlomi-noach Jul 26, 2023
3c609c8
clarification
shlomi-noach Jul 26, 2023
1dbde73
boolean vars confused with positional args
shlomi-noach Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions go/test/endtoend/onlineddl/revert/onlineddl_revert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ func TestMain(m *testing.M) {
"--migration_check_interval", "5s",
"--queryserver-config-schema-change-signal-interval", "0.1",
"--watch_replication_stream",
// The next flags are deprecated, and we incldue them to verify that they are nonetheless still allowed.
// The values are irrelevant. Just the fact that the flags are allowed in what's important.
// These should be included in v18, and removed in v19.
"--throttle_threshold", "1m",
"--throttle_metrics_query", "select 1 from dual",
"--throttle_metrics_threshold", "1.5",
"--throttle_check_as_check_self=false",
"--throttler-config-via-topo=true",
}
clusterInstance.VtGateExtraArgs = []string{
"--ddl_strategy", "online",
Expand Down