-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] bugfixes: collection of fixes to bugs found while fuzzing #13805
Merged
GuptaManan100
merged 3 commits into
vitessio:release-16.0
from
planetscale:fix-inconsistencies-16
Aug 18, 2023
Merged
[16.0] bugfixes: collection of fixes to bugs found while fuzzing #13805
GuptaManan100
merged 3 commits into
vitessio:release-16.0
from
planetscale:fix-inconsistencies-16
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3332) * bugfix: left join predicate only depending on RHS turns into inner join Signed-off-by: Andres Taylor <andres@planetscale.com> * bugfix: use the incoming type fields to calculate the outgoing types Signed-off-by: Andres Taylor <andres@planetscale.com> * bugfix: filter was using wrong method on evalengine Signed-off-by: Andres Taylor <andres@planetscale.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
August 17, 2023 12:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 17, 2023
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Aug 17, 2023
GuptaManan100
approved these changes
Aug 17, 2023
harshit-gangal
approved these changes
Aug 17, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
merged commit Aug 18, 2023
bafc21d
into
vitessio:release-16.0
111 of 112 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes three one-line issues.
1
instead of using MySQLs coercion to boolRelated Issue(s)
This was found with automated query fuzzing (#13279)
Backport of #13332
Checklist