Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtctldclient OnlineDDL CANCEL #13860

Merged
merged 7 commits into from
Aug 28, 2023
Merged

vtctldclient OnlineDDL CANCEL #13860

merged 7 commits into from
Aug 28, 2023

Commits on Aug 27, 2023

  1. vtctldclient OnlineDDL CANCEL 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    be87a3e View commit details
    Browse the repository at this point in the history

  2. improved error message 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    35dbb2f View commit details
    Browse the repository at this point in the history

  3. ToLower() 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    837d4c6 View commit details
    Browse the repository at this point in the history

  4. verify ALL case-insensitivity 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    2940b9f View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. fix placement 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fb09489 View commit details
    Browse the repository at this point in the history

  2. Update go/cmd/vtctldclient/command/onlineddl.go 

    Co-authored-by: Andrew Mason <amason@hey.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach @ajm188
    shlomi-noach and ajm188 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    dafe427 View commit details
    Browse the repository at this point in the history

  3. lower case comment 

    Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b692171 View commit details
    Browse the repository at this point in the history