Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move DML logic to sql_builder.go #13920

Merged
merged 4 commits into from
Sep 8, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use error instead of panic
Signed-off-by: Andres Taylor <andres@planetscale.com>
  • Loading branch information
systay committed Sep 8, 2023
commit ca307e8a860712a2cf4ec63fa4abdf30379577b7
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operator_transformers.go
Original file line number Diff line number Diff line change
@@ -418,7 +418,7 @@ func transformRoutePlan(ctx *plancontext.PlanningContext, op *operators.Route) (
case *sqlparser.Insert:
return buildInsertLogicalPlan(ctx, op, dmlOp, stmt)
default:
panic(fmt.Sprintf("dont know how to %T", stmt))
return nil, vterrors.VT13001(fmt.Sprintf("dont know how to %T", stmt))
}
}