Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in TestWarmingReads #14187

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix data race in TestWarmingReads #14187

merged 1 commit into from
Oct 5, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the data race as pointed out in #14186.

The data race was happening on the replica tablet. In the test TestWarmingReads, warming read queries are run on the replica asynchronously. This lead to the Queries field in the sandboxconn being updated in a separate go-routine than the main go routine. This causes the read and writes to this variable in the main go routine to error with a data race.

This has been fixed in this PR by adding synchronization to that variable. This however has been added only when it is required so as to not hamper performance of the other tests.

The test TestWarmingReads was introduced in #13206

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: fix data race in TestWarmingReads
e364c9e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 5, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 5, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 5, 2023
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 5, 2023
@rohit-nayak-ps rohit-nayak-ps requested a review from a team October 5, 2023 08:23
shlomi-noach
shlomi-noach approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@shlomi-noach shlomi-noach merged commit 22f1f7d into vitessio:main Oct 5, 2023
118 of 121 checks passed
@shlomi-noach shlomi-noach deleted the flaky-test-test-warmingreads branch October 5, 2023 08:32
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot @olyazavr @GuptaManan100
CherryPick(#13206): add option for warming reads to mirror primary re…
9de4a56 
…ad queries onto replicas from vtgates to warm bufferpools (#3301)

* add option for warming reads to mirror primary read queries onto replicas from vtgates to warm bufferpools (#13206)

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
Signed-off-by: Olga Shestopalova <olgash@mit.edu>
Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix boost

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Fix data race in `TestWarmingReads` (#14187)

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
Signed-off-by: Olga Shestopalova <olgash@mit.edu>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Olga Shestopalova <olgash@mit.edu>
Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: Query Serving Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Data Race in TestWarmingReads
3 participants
@GuptaManan100 @shlomi-noach @rohit-nayak-ps