-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtgate: Allow additional errors in warnings test #14461
Merged
rohit-nayak-ps
merged 1 commit into
vitessio:main
from
planetscale:dbussink/more-allowed-warnings
Nov 4, 2023
Merged
vtgate: Allow additional errors in warnings test #14461
rohit-nayak-ps
merged 1 commit into
vitessio:main
from
planetscale:dbussink/more-allowed-warnings
Nov 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an additional error that we can see in this errors as warnings check. It refactors it slightly to have one list instead that isn't on a huge single line. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
requested review from
harshit-gangal,
systay and
frouioui
as code owners
November 4, 2023 13:54
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 4, 2023
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 4, 2023
deepthi
approved these changes
Nov 4, 2023
rohit-nayak-ps
approved these changes
Nov 4, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Nov 4, 2023
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
harshit-gangal
pushed a commit
that referenced
this pull request
Nov 10, 2023
…) (#14465) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
harshit-gangal
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
deepthi
pushed a commit
to planetscale/vitess
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
pushed a commit
that referenced
this pull request
Nov 10, 2023
…) (#14463) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
harshit-gangal
pushed a commit
that referenced
this pull request
Nov 15, 2023
…) (#14464) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Deepthi Sigireddi <deepthi@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an additional error that we can see in this errors as warnings check.
It refactors it slightly to have one list instead that isn't on a huge single line.
Related Issue(s)
Follow up to #14421
Checklist