-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-16.0] fix concurrency on stream execute engine primitives (#14586) #14590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitess-bot
bot
added
Backport
This is a backport
Component: Query Serving
Merge Conflict
Skip CI
Skip CI actions from running
Type: Bug
labels
Nov 23, 2023
Hello @harshit-gangal, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace
|
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
requested review from
GuptaManan100,
harshit-gangal and
systay
November 23, 2023 11:14
Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
harshit-gangal
force-pushed
the
backport-14586-to-release-16.0
branch
from
November 23, 2023 11:39
703a482
to
e86b889
Compare
harshit-gangal
requested review from
frouioui,
shlomi-noach and
vmg
as code owners
November 23, 2023 11:39
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
backport-14586-to-release-16.0
branch
from
November 23, 2023 11:49
8cec45b
to
6c40f5b
Compare
harshit-gangal
requested review from
ajm188,
deepthi,
mattlord and
rohit-nayak-ps
as code owners
November 23, 2023 11:49
harshit-gangal
approved these changes
Nov 23, 2023
dbussink
approved these changes
Nov 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #14586