Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET #14612

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with WAIT_FOR_EXECUTED_GTID_SET #14612

merged 1 commit into from
Nov 27, 2023

Conversation

shlomi-noach
Copy link
Contributor

Description

See #14611 for details. In 8.2.0 the function WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS is removed, and we must therefore use WAIT_FOR_EXECUTED_GTID_SET instead.

The two functions have the same signature assuming no channel argument is used -- which isn't in our case. Therefore I've made no changes to any tests: everything should continue to work in the exact same way, and we expect all existing tests to pass.

Related Issue(s)

Closes #14611

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
0b1b9bd 
…CUTED_GTID_SET`

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 27, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 27, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 27, 2023
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 27, 2023
@shlomi-noach
Copy link
Contributor Author

Worth noting: I have not removed sqlparser support for WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS.

@shlomi-noach shlomi-noach added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Nov 27, 2023
@dbussink
Copy link
Contributor

Worth noting: I have not removed sqlparser support for WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS.

I think that's correct, since our parser is kind of the superset of all supported MySQL versions and it definitely still works in 8.0 etc.

@rohit-nayak-ps rohit-nayak-ps merged commit f8348c7 into vitessio:main Nov 27, 2023
120 of 122 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the deprecate-mysql-gtid-func branch November 27, 2023 14:30
vitess-bot pushed a commit that referenced this pull request Nov 27, 2023
@vitess-bot
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
fbacc7a 
…CUTED_GTID_SET` (#14612)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot mentioned this pull request Nov 27, 2023
Merged
@shlomi-noach
Copy link
Contributor Author

I should have backported to release-17.0 and release-16.0, as well. Will open manual PRs.

shlomi-noach added a commit to planetscale/vitess that referenced this pull request Nov 27, 2023
@shlomi-noach
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
d90e030 
…CUTED_GTID_SET` (vitessio#14612)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach added a commit to planetscale/vitess that referenced this pull request Nov 27, 2023
@shlomi-noach
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
8c8f69d 
…CUTED_GTID_SET` (vitessio#14612)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
This was referenced Nov 27, 2023
Merged
Merged
@shlomi-noach
Copy link
Contributor Author

Manual backports:

shlomi-noach pushed a commit that referenced this pull request Nov 27, 2023
@vitess-bot
[release-18.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS wit…
654c1bf 
…h `WAIT_FOR_EXECUTED_GTID_SET` (#14612) (#14617)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach added a commit that referenced this pull request Nov 28, 2023
@shlomi-noach
[release-17.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS wit…
29d3784 
…h `WAIT_FOR_EXECUTED_GTID_SET` (#14612) (#14619)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach added a commit that referenced this pull request Nov 28, 2023
@shlomi-noach
[release-16.0] Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS wit…
151b1b0 
…h `WAIT_FOR_EXECUTED_GTID_SET` (#14612) (#14620)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi deepthi mentioned this pull request Dec 9, 2023
Closed
4 tasks
deepthi added a commit to planetscale/vitess that referenced this pull request Dec 9, 2023
@deepthi
Revert "[release-18.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
b526e5d 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14617)"

This reverts commit 654c1bf.

Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi added a commit to planetscale/vitess that referenced this pull request Dec 9, 2023
@deepthi
Revert "[release-17.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
4715e3a 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14619)"

This reverts commit 29d3784.

Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi added a commit to planetscale/vitess that referenced this pull request Dec 9, 2023
@deepthi
Revert "[release-16.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
358d4e5 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620)"

This reverts commit 151b1b0.

Signed-off-by: deepthi <deepthi@planetscale.com>
GuptaManan100 pushed a commit that referenced this pull request Dec 11, 2023
@deepthi
Revert "[release-18.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
870675b 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (#14612)" (#14742)

Signed-off-by: deepthi <deepthi@planetscale.com>
GuptaManan100 pushed a commit that referenced this pull request Dec 11, 2023
@deepthi
Revert "[release-17.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
4cb4856 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (#14612)" (#14744)

Signed-off-by: deepthi <deepthi@planetscale.com>
GuptaManan100 pushed a commit to planetscale/vitess that referenced this pull request Dec 11, 2023
@deepthi @GuptaManan100
Revert "[release-16.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
4423423 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (vitessio#14612) (vitessio#14620)"

This reverts commit 151b1b0.

Signed-off-by: deepthi <deepthi@planetscale.com>
GuptaManan100 added a commit that referenced this pull request Dec 11, 2023
@deepthi @GuptaManan100
Revert "[release-16.0] Replace use of `WAIT_UNTIL_SQL_THREAD_AFTER_GT…
307fb6d 
…IDS` with `WAIT_FOR_EXECUTED_GTID_SET` (#14612)" (#14743)

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@deepthi deepthi mentioned this pull request Dec 11, 2023
Merged
4 tasks
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@shlomi-noach @ejortegau
Replace use of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS with `WAIT_FOR_EXE…
34127dd 
…CUTED_GTID_SET` (vitessio#14612)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@deepthi deepthi added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: TabletManager Type: Internal Cleanup and removed Type: Bug Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 13, 2023
@deepthi
Copy link
Member

deepthi commented Dec 13, 2023

I wanted to re-classify this PR - it's not actually a bug, it's addressing a deprecation warning from MySQL. After some debate, I decided to label it as Internal Cleanup. I also changed the component - this is not a query serving issue at all, it is a tablet manager issue.

@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

Assignees
No one assigned
Labels
Component: TabletManager Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.

Adapt Vitess to MySQL deprecation of WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS
4 participants
@shlomi-noach @dbussink @deepthi @rohit-nayak-ps