[release-18.0] Backport: VReplication SwitchWrites: Properly return errors in SwitchWrites #14800 #14824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tessio#14800) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
added
Type: Bug
Component: VReplication
Backport
mattlord
approved these changes
Dec 19, 2023
|
Manually created backport: missed adding the Backport label for release 18.0 in main. The original PR is part of release 18.0. |
dbussink
approved these changes
Dec 20, 2023
shlomi-noach
approved these changes
Dec 20, 2023
harshit-gangal
merged commit 6e7937c
into
vitessio:release-18.0
116 of 118 checks passed
harshit-gangal
deleted the
rohit/fix-incorrect-traffic-switcher-error-handling-18.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #14800
During a refactor there was a regression where some errors were just being logged and not returned. This PR correctly returns them to the caller.
Original commit where this was introduced: 89295b5#diff-a071a972abd45af831ed93cc6447a87b83cee112f1c7d3bb0bdd592979d80c91
Related Issue(s)
#13656
#14801
Checklist
Deployment Notes