New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`schemadiff`: fix diffing of textual columns with implicit charsets #14930

Merged

GuptaManan100 merged 12 commits into vitessio:main from planetscale:schemadiff-charset-columns-table

Jan 12, 2024

Merged

`schemadiff`: fix diffing of textual columns with implicit charsets #14930

testing change of charset to default

Codecov / codecov/patch succeeded Jan 10, 2024 in 0s

67.90% of diff hit (target 47.26%)

View this Pull Request on Codecov

67.90% of diff hit (target 47.26%)

Annotations

Check warning on line 119 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L115-L119

Added lines #L115 - L119 were not covered by tests

Check warning on line 124 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L121-L124

Added lines #L121 - L124 were not covered by tests

Check warning on line 150 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L147-L150

Added lines #L147 - L150 were not covered by tests

Check warning on line 156 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L153-L156

Added lines #L153 - L156 were not covered by tests

Check warning on line 162 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L159-L162

Added lines #L159 - L162 were not covered by tests

Check warning on line 946 in go/vt/schemadiff/table.go

codecov / codecov/patch

go/vt/schemadiff/table.go#L945-L946

Added lines #L945 - L946 were not covered by tests

View more details on Codecov