-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VStreamer: add throttled logs when row/result/vstreamers get throttled. #14936
VStreamer: add throttled logs when row/result/vstreamers get throttled. #14936
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14936 +/- ##
===========================================
- Coverage 47.28% 38.90% -8.38%
===========================================
Files 1136 1643 +507
Lines 238587 384592 +146005
===========================================
+ Hits 112823 149638 +36815
- Misses 117147 219105 +101958
- Partials 8617 15849 +7232 ☔ View full report in Codecov by Sentry. |
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Description
Currently we don't log when a rowstreamer, resultstreamer or vstreamer gets throttled. There are times when, due to configuration issues or a replication lag, these can get throttled permanently or for long. We do log this in the target's vreplication row and in debug/vars, but there are times when we only have access to the past logs.
The throttler checks every 250ms, which is obviously too often to log. This PR uses the
ThrottledLogger
to log every five minutes to improve visibility.Related Issue(s)
Checklist
Deployment Notes