Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VStreamer: add throttled logs when row/result/vstreamers get throttled. #14936

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

Currently we don't log when a rowstreamer, resultstreamer or vstreamer gets throttled. There are times when, due to configuration issues or a replication lag, these can get throttled permanently or for long. We do log this in the target's vreplication row and in debug/vars, but there are times when we only have access to the past logs.

The throttler checks every 250ms, which is obviously too often to log. This PR uses the ThrottledLogger to log every five minutes to improve visibility.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Component: Observability Pull requests that touch tracing/metrics/monitoring labels Jan 11, 2024
Copy link
Contributor

vitess-bot bot commented Jan 11, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 11, 2024
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 11, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 38.90%. Comparing base (961a978) to head (a5ca0a5).
Report is 256 commits behind head on main.

Files Patch % Lines
.../vttablet/tabletserver/vstreamer/resultstreamer.go 66.66% 1 Missing ⚠️
.../vt/vttablet/tabletserver/vstreamer/rowstreamer.go 50.00% 1 Missing ⚠️
go/vt/vttablet/tabletserver/vstreamer/vstreamer.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #14936       +/-   ##
===========================================
- Coverage   47.28%   38.90%    -8.38%     
===========================================
  Files        1136     1643      +507     
  Lines      238587   384592   +146005     
===========================================
+ Hits       112823   149638    +36815     
- Misses     117147   219105   +101958     
- Partials     8617    15849     +7232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui modified the milestones: v19.0.0, v20.0.0 Feb 6, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels Mar 8, 2024
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps merged commit 2ee5946 into vitessio:main Mar 15, 2024
101 of 102 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/log-throttled branch March 15, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VReplication Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants