Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planner Bug: Joins inside derived table #14974

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Planner Bug: Joins inside derived table #14974

merged 14 commits into from
Feb 8, 2024

Commits on Feb 6, 2024

  1. refactor: remove the Predicate field from ApplyJoin 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    723997a View commit details
    Browse the repository at this point in the history

  2. Update short description of applyjoin 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui @systay
    frouioui authored and systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1bf87e8 View commit details
    Browse the repository at this point in the history

  3. refactor: extract common helper method 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ae10ee0 View commit details
    Browse the repository at this point in the history

  4. refactor: move projection pushing to it's own file 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    371c159 View commit details
    Browse the repository at this point in the history

  5. minor edits 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d11d954 View commit details
    Browse the repository at this point in the history

  6. fix apply join 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui @systay
    frouioui authored and systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    eb0f1b5 View commit details
    Browse the repository at this point in the history

  7. update ApplyJoin.ShortDesription again 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    fdb8c65 View commit details
    Browse the repository at this point in the history

  8. feat: update how we expose columns from derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7fe7e6e View commit details
    Browse the repository at this point in the history

  9. minor edits after self-review 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7754ade View commit details
    Browse the repository at this point in the history

  10. Update go/vt/vtgate/planbuilder/operators/projection_pushing.go 

    Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Signed-off-by: Andrés Taylor <andres@taylor.se>
    @systay @frouioui
    systay and frouioui committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5d30fd0 View commit details
    Browse the repository at this point in the history

  11. planner fix: only expose columns being returned from the RHS 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4c8e0e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. wip - stop columns from inside subqueries from leaking out 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4e8dd5c View commit details
    Browse the repository at this point in the history

  2. bugfix: push down the correct subquery expression from derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fe34b01 View commit details
    Browse the repository at this point in the history

  3. test: clean up 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    57aed9b View commit details
    Browse the repository at this point in the history