-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Add MID alias #15066
Merged
Merged
evalengine: Add MID alias #15066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
January 29, 2024 11:24
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 29, 2024
dbussink
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Evalengine
changes to the evaluation engine
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jan 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15066 +/- ##
==========================================
+ Coverage 47.64% 47.65% +0.01%
==========================================
Files 1151 1151
Lines 239809 239809
==========================================
+ Hits 114256 114281 +25
+ Misses 116950 116926 -24
+ Partials 8603 8602 -1 ☔ View full report in Codecov by Sentry. |
dbussink
force-pushed
the
add-mid-synonym
branch
from
January 29, 2024 13:04
5a69393
to
c05ecda
Compare
systay
approved these changes
Jan 29, 2024
dbussink
force-pushed
the
add-mid-synonym
branch
from
January 29, 2024 13:07
c05ecda
to
55f3a56
Compare
This is a synonym for SUBSTRING so let's add it as such. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
add-mid-synonym
branch
from
January 29, 2024 13:24
55f3a56
to
7c9cba1
Compare
vmg
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Evalengine
changes to the evaluation engine
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a synonym for SUBSTRING so let's add it as such.
Related Issue(s)
Part of #9647
Checklist