Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Multi-tenant import support in Vitess #15128

Closed
wants to merge 27 commits into from
Closed

Experimental: Multi-tenant import support in Vitess #15128

wants to merge 27 commits into from

Commits on Mar 4, 2024

  1. Initial commit for adding filter clause to MoveTables. Working e2e test. 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    7b97add View commit details
    Browse the repository at this point in the history

  2. Fix failing unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f680c67 View commit details
    Browse the repository at this point in the history

  3. Fix failing unit and e2e tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5a89e9c View commit details
    Browse the repository at this point in the history

  4. fix failing unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    633e817 View commit details
    Browse the repository at this point in the history

  5. Fix incorrect logic for getting reverse replication filter 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    9767c52 View commit details
    Browse the repository at this point in the history

  6. Fix vreplication unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    645a313 View commit details
    Browse the repository at this point in the history

  7. Fix logic for adding additional filter in reverse workflows 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    764d39b View commit details
    Browse the repository at this point in the history

  8. Fix a bunch of failing unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    82412b4 View commit details
    Browse the repository at this point in the history

  9. Add Keyspace Routing Rules to proto and functions to get/put the rules 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    95c7742 View commit details
    Browse the repository at this point in the history

  10. Use keyspace routing rules in vtgate 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    04327be View commit details
    Browse the repository at this point in the history

  11. Remove compressed rules for now, until we come up with a better abstr… 

    …action for them. Add vtctldclient cli commands for Apply/Get KeyspaceRoutingRules

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    416cb18 View commit details
    Browse the repository at this point in the history

  12. Add flags for keyspace routing rules in MoveTables. Add rules when cr… 

    …eating the workflow and switching traffic.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8c21354 View commit details
    Browse the repository at this point in the history

  13. Working e2e test for single tenant migration with keyspace routing ru… 

    …les.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    092d5b0 View commit details
    Browse the repository at this point in the history

  14. Protect map access with mutexes in e2e test. Make function scope priv… 

    …ate to tests.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    91481b9 View commit details
    Browse the repository at this point in the history

  15. Make proto 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e81e873 View commit details
    Browse the repository at this point in the history

  16. Fix failing unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    d2617f6 View commit details
    Browse the repository at this point in the history

  17. Generate flags help text 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dade06e View commit details
    Browse the repository at this point in the history

  18. Fix failing unit tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b753df4 View commit details
    Browse the repository at this point in the history

  19. Improve e2e test by creating more tenants and randomize the workflow … 

    …steps

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f46061f View commit details
    Browse the repository at this point in the history

  20. Compression tests 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c34783f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Revert compression test. For now we are going to assume keyspace rout… 

    …ing rules will not be large

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ba8e428 View commit details
    Browse the repository at this point in the history

  2. Address a couple of review comments 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    55c7df6 View commit details
    Browse the repository at this point in the history

  3. Address more review comments. Refactor the e2e test.The refactor of F… 

    …uncExpr required a change in a unit test helper. Uncomment frozen workflow code for now so that unit tests run.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9b6b640 View commit details
    Browse the repository at this point in the history

  4. Allow creating new MoveTables workflows when there are previous Froze… 

    …n workflows

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    eedb210 View commit details
    Browse the repository at this point in the history

  5. Fix unit tests for removal of the frozen check 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    afaa323 View commit details
    Browse the repository at this point in the history

  6. Reduce number of tenants in e2e test to make it run in a reasonable t… 

    …ime in CI. Let it run in its own workflow for now to isolate any issues and allow running it several times

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3343c15 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Fix check in reverse traffic to account for keyspace routing rules. A… 

    …dd ReverseTraffic to e2e tests. Some refactor of e2e test.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6ab42cc View commit details
    Browse the repository at this point in the history