evalengine: Implement LOCATE and friends #15195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Enhancement
dbussink
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
mattlord
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
commented
Feb 9, 2024
| to = len(src) | ||
| } | ||
| return src[from:to] | ||
| } |
There was a problem hiding this comment.
Added a number of these optimized / simplified implementations where possible as well (we check for this interface when slicing in the helper).
dbussink
removed
NeedsDescriptionUpdate
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #15195 +/- ##
===========================================
+ Coverage 47.29% 67.36% +20.06%
===========================================
Files 1137 1560 +423
Lines 238684 192576 -46108
===========================================
+ Hits 112895 129733 +16838
+ Misses 117168 62843 -54325
+ Partials 8621 0 -8621 ☔ View full report in Codecov by Sentry. |
dbussink
commented
Feb 10, 2024
| @@ -719,7 +725,7 @@ func (ast *astCompiler) translateCallable(call sqlparser.Callable) (IR, error) { | |||
|
|
|||
| case *sqlparser.CurTimeFuncExpr: | |||
| if call.Fsp > 6 { | |||
| return nil, vterrors.Errorf(vtrpcpb.Code_INVALID_ARGUMENT, "Too-big precision 12 specified for '%s'. Maximum is 6.", call.Name.String()) | |||
| return nil, vterrors.Errorf(vtrpcpb.Code_INVALID_ARGUMENT, "Too-big precision %d specified for '%s'. Maximum is 6.", call.Fsp, call.Name.String()) | |||
There was a problem hiding this comment.
This was incorrectly hardcoding a value instead of using the one provided by the user.
5 tasks
dbussink
force-pushed
the
locate-and-friends
branch
from
a18d001 to
93316a1
Compare
dbussink
commented
Feb 10, 2024
| @@ -282,8 +282,8 @@ func (b *builtinDateFormat) eval(env *ExpressionEnv) (eval, error) { | |||
| case *evalTemporal: | |||
| t = e.toDateTime(datetime.DefaultPrecision, env.now) | |||
| default: | |||
| t = evalToDateTime(date, datetime.DefaultPrecision, env.now, env.sqlmode.AllowZeroDate()) | |||
| if t == nil || t.isZero() { | |||
There was a problem hiding this comment.
Did a little cleanup of the zero date handling as well, since it's equivalent to convert not allowing zero dates if we check against nil and the zero date anyway.
dbussink
force-pushed
the
locate-and-friends
branch
2 times, most recently
from
13a3d83 to
4416195
Compare
vmg
approved these changes
Feb 12, 2024
This implements `LOCATE`, `POSITION` and `INSTR` to find substrings inside another string. It diverges in behavior for multibyte characters because of the bugs in MySQL identified in https://bugs.mysql.com/bug.php?id=113933. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
We have a bunch of cases where we convert to zero date with the runtime flag, but then check both nil and zero date. It's equivalent to convert without allowing zero dates to simplify the code here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
force-pushed
the
locate-and-friends
branch
from
4416195 to
789bbad
Compare
frouioui
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
LOCATE,POSITIONandINSTRto find substrings inside another string.It diverges in behavior for multibyte characters because of the bugs in MySQL identified in https://bugs.mysql.com/bug.php?id=113933.
Related Issue(s)
Part of #9647
Checklist