CI: Address data races on memorytopo Conn.closed #15365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the seen data races on the variable. Signed-off-by: Matt Lord <mattalord@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
mattlord
added
Backport to: release-17.0
Backport to: release-18.0
mattlord
changed the title
mattlord
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15365 +/- ##
==========================================
- Coverage 67.41% 65.41% -2.01%
==========================================
Files 1560 1561 +1
Lines 192752 193596 +844
==========================================
- Hits 129952 126647 -3305
- Misses 62800 66949 +4149 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Feb 26, 2024
This was referenced Feb 27, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Feb 27, 2024
…) (#15369) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Feb 27, 2024
…) (#15370) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Mar 6, 2024
…) (#15371) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 12, 2024
… data races on memorytopo Conn.closed (vitessio#4555) * backport of 4549 * Fix import conflict Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves the seen data races on the variable: https://github.com/vitessio/vitess/actions/runs/8054421738/job/21999131114?pr=15361
Click here to see example data races
We should backport this to v17 to limit CI test failures and work for other PRs that we backport.
Related Issue(s)
Checklist