-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add required tests for go/mysql/collations/charset
#15435
test: Add required tests for go/mysql/collations/charset
#15435
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15435 +/- ##
=======================================
Coverage 65.64% 65.65%
=======================================
Files 1563 1563
Lines 194389 194389
=======================================
+ Hits 127602 127621 +19
+ Misses 66787 66768 -19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds required tests for
go/mysql/collations/charset
Related Issue(s)
Checklist
Deployment Notes