Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Multi-tenant import support in Vitess #15503

Merged
merged 52 commits into from
Apr 1, 2024

Address review comments

36027f3
Select commit
Failed to load commit list.
Merged

Experimental: Multi-tenant import support in Vitess #15503

Address review comments
36027f3
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Apr 1, 2024 in 0s

68.01% (+2.23%) compared to e5eb981

View this Pull Request on Codecov

68.01% (+2.23%) compared to e5eb981

Details

Codecov Report

Attention: Patch coverage is 35.54084% with 292 lines in your changes are missing coverage. Please review.

Project coverage is 68.01%. Comparing base (e5eb981) to head (36027f3).
Report is 3 commits behind head on main.

Files Patch % Lines
go/vt/vtctl/workflow/server.go 43.26% 59 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 10.76% 58 Missing ⚠️
go/vt/vtctl/workflow/utils.go 14.92% 57 Missing ⚠️
...cmd/vtctldclient/command/keyspace_routing_rules.go 12.90% 54 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 0.00% 22 Missing ⚠️
go/vt/vtctl/workflow/materializer.go 59.37% 13 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 8 Missing ⚠️
go/vt/topo/vschema.go 71.42% 6 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15503      +/-   ##
==========================================
+ Coverage   65.78%   68.01%   +2.23%     
==========================================
  Files        1561     1562       +1     
  Lines      194838   195606     +768     
==========================================
+ Hits       128171   133051    +4880     
+ Misses      66667    62555    -4112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov