-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtorc: Cleanup unused code #15508
Merged
Merged
vtorc: Cleanup unused code #15508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used `deadcode` to find all unused code inside `vtorc` and cleans it up. Ran it both with and without the `-test` flag to also find code that is only exercised from tests and not from anywhere else. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
added
Type: Internal Cleanup
Component: VTorc
Vitess Orchestrator integration
labels
Mar 18, 2024
dbussink
requested review from
deepthi,
shlomi-noach and
GuptaManan100
as code owners
March 18, 2024 09:48
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 18, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15508 +/- ##
==========================================
- Coverage 65.67% 65.66% -0.02%
==========================================
Files 1563 1561 -2
Lines 194474 194272 -202
==========================================
- Hits 127727 127560 -167
+ Misses 66747 66712 -35 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Mar 18, 2024
shlomi-noach
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used
deadcode
to find all unused code insidevtorc
and cleans it up. Ran it both with and without the-test
flag to also find code that is only exercised from tests and not from anywhere else.Checklist