Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove keyspace from column during query builder #15514

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

harshit-gangal
Copy link
Member

Description

This PR removes the keyspace information from the final query sent down to vttablet for execution as the database name and keyspace name can be different.

This was caused by to recent change in fixing the order by, group by and having clause column resolution logic to match the MySQL rules.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Mar 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 18, 2024
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 18, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 18, 2024
@harshit-gangal harshit-gangal changed the title fix: remove keyspace from column dureing query builder fix: remove keyspace from column during query builder Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (61db2db) to head (0edaab0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15514      +/-   ##
==========================================
+ Coverage   65.69%   65.70%   +0.01%     
==========================================
  Files        1564     1562       -2     
  Lines      194588   194438     -150     
==========================================
- Hits       127832   127753      -79     
+ Misses      66756    66685      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arthurschreiber arthurschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@harshit-gangal harshit-gangal merged commit a1acdde into vitessio:main Mar 19, 2024
117 checks passed
@harshit-gangal harshit-gangal deleted the orderby-expansion-fix branch March 19, 2024 06:03
vitess-bot pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal pushed a commit that referenced this pull request Mar 19, 2024
…15514) (#15517)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
harshit-gangal added a commit that referenced this pull request Mar 19, 2024
…15514) (#15516)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Query Serving Type: Bug Type: Regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Some query with filter fails since v19.0.0
5 participants