Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign Key: Add support for Multi Table and Multi Target Update Statement #15523

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Foreign Key: Add support for Multi Table and Multi Target Update Statement #15523

merged 3 commits into from
Mar 21, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 19, 2024 •
edited
Loading

Description

This PR adds support for tables with foreign key in multi-table and multi-target update statements.

E.g.
update user join music on user.foo = music.bar set user.id = 4, music.col = 5 where user.baz = 20

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 19, 2024
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 19, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 19, 2024
@harshit-gangal harshit-gangal added the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Mar 19, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (696fe0e) to head (30bff59).
Report is 133 commits behind head on main.

❗ Current head 30bff59 differs from pull request most recent head 657f2b3. Consider uploading reports for the commit 657f2b3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15523      +/-   ##
==========================================
- Coverage   67.41%   65.72%   -1.70%     
==========================================
  Files        1560     1560              
  Lines      192752   194497    +1745     
==========================================
- Hits       129952   127830    -2122     
- Misses      62800    66667    +3867

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal harshit-gangal changed the title Foreign key support for Multi Table and Multi Target Update Statement Foreign Key: Add support for Multi Table and Multi Target Update Statement Mar 19, 2024
@harshit-gangal
Copy link
Member Author

Build on top of #15504. I will rebase once that PR is merged.

@harshit-gangal
plan for multi table and multi target update statement
ef2fe09 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix: table qualifier in fk select query column
30bff59 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
test: added e2e and fuzz test
657f2b3 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Mar 20, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review March 20, 2024 11:30
shlomi-noach
shlomi-noach approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is so small! Approving as this looks very clean, and based on the tests.

go/test/endtoend/vtgate/foreignkey/fk_fuzz_test.go
@@ -151,8 +151,17 @@ func (fz *fuzzer) generateInsertDMLQuery(insertType string) string {
}
}

// generateUpdateDMLQuery generates an UPDATE query from the parameters for the fuzzer.
// generateUpdateDMLQuery generates a UPDATE query from the parameters for the fuzzer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an was just fine? Later in the PR you actually turn a to an 😅

@harshit-gangal harshit-gangal merged commit 943b07c into vitessio:main Mar 21, 2024
100 of 101 checks passed
@harshit-gangal harshit-gangal deleted the fk-multitarget-upd branch March 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@dbussink dbussink dbussink approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @dbussink @shlomi-noach