-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Implement TO_SECONDS
#15590
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15590 +/- ##
=======================================
Coverage 65.78% 65.79%
=======================================
Files 1561 1561
Lines 194838 194897 +59
=======================================
+ Hits 128183 128223 +40
- Misses 66655 66674 +19 ☔ View full report in Codecov by Sentry. |
Description
This PR adds implementation of TO_SECONDS func in evalengine.
Related Issue(s)
Checklist
Deployment Notes