-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-tenant migrations: add topo locking while updating keyspace routing rules #15807
Multi-tenant migrations: add topo locking while updating keyspace routing rules #15807
Commits on May 5, 2024
-
Add keyspace routing rules lock. Use it while updating rules
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for d716243 - Browse repository at this point
Copy the full SHA d716243View commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for bc1512d - Browse repository at this point
Copy the full SHA bc1512dView commit details -
Fix locking logic and related tests
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for f5ae07c - Browse repository at this point
Copy the full SHA f5ae07cView commit details -
Refactor topo lock, remove unnecessary stuff
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 50cc2b6 - Browse repository at this point
Copy the full SHA 50cc2b6View commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 0c935d6 - Browse repository at this point
Copy the full SHA 0c935d6View commit details -
Single entry point for serializing all functionalities updating keysp…
…ace routing rules Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 254aa1d - Browse repository at this point
Copy the full SHA 254aa1dView commit details -
Delete keyspace routing rules on Cancel
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for cc8b452 - Browse repository at this point
Copy the full SHA cc8b452View commit details -
Add test to confirm that concurrent updates don't overwrite each other
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 6f711b1 - Browse repository at this point
Copy the full SHA 6f711b1View commit details -
Update reasons for generic locking
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for a3b761f - Browse repository at this point
Copy the full SHA a3b761fView commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 5f1e8ec - Browse repository at this point
Copy the full SHA 5f1e8ecView commit details -
Add concurrency tests for a specific topo to confirm that it works fo…
…r a 'real' topo implementation in addition to memtopo Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 682b00c - Browse repository at this point
Copy the full SHA 682b00cView commit details -
Address review comments. Change the key paths where rules and locks a…
…re created Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 5e27c79 - Browse repository at this point
Copy the full SHA 5e27c79View commit details -
Modify comments/logs to reflect the sentinel nomenclature
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 8047f35 - Browse repository at this point
Copy the full SHA 8047f35View commit details
Commits on May 6, 2024
-
Signed-off-by: Matt Lord <mattalord@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f639c60 - Browse repository at this point
Copy the full SHA f639c60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6119992 - Browse repository at this point
Copy the full SHA 6119992View commit details -
Signed-off-by: Matt Lord <mattalord@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 23dc487 - Browse repository at this point
Copy the full SHA 23dc487View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0aef45 - Browse repository at this point
Copy the full SHA b0aef45View commit details
Commits on May 8, 2024
-
Address review comment: Remove space from name
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 70b59d4 - Browse repository at this point
Copy the full SHA 70b59d4View commit details -
Address review comment: remove export of global cell. Move key creati…
…on logic to topo server Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 74e16ed - Browse repository at this point
Copy the full SHA 74e16edView commit details -
Address Review Comment: rename updateKeyspaceRoutingRule to updateKey…
…spaceRoutingRules Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 506475f - Browse repository at this point
Copy the full SHA 506475fView commit details -
Change the mechanism of updating keyspace routing rules under the loc…
…k for MoveTables actions. ApplyKeyspaceRoutingRules has been commented out temporarily Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for c993e8c - Browse repository at this point
Copy the full SHA c993e8cView commit details
Commits on May 9, 2024
-
Change topo paths for keyspace routing rules
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 7b90ed6 - Browse repository at this point
Copy the full SHA 7b90ed6View commit details -
Change ApplyKeyspaceRoutingRules to return current and new rules. Add…
… e2e test for it Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 6452e4c - Browse repository at this point
Copy the full SHA 6452e4cView commit details
Commits on May 10, 2024
-
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for de3b3e9 - Browse repository at this point
Copy the full SHA de3b3e9View commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 309f594 - Browse repository at this point
Copy the full SHA 309f594View commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 5ecdafc - Browse repository at this point
Copy the full SHA 5ecdafcView commit details -
Confirm that we hold the lock while saving keyspace routing rules. Ad…
…d test. Some additional comments Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for a9c4574 - Browse repository at this point
Copy the full SHA a9c4574View commit details -
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 461a0b6 - Browse repository at this point
Copy the full SHA 461a0b6View commit details
Commits on May 11, 2024
-
Move setting response parameters to the vtctld server instead of on t…
…he client side Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for f483725 - Browse repository at this point
Copy the full SHA f483725View commit details
Commits on May 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8a22e7e - Browse repository at this point
Copy the full SHA 8a22e7eView commit details -
Don't send old rules on ApplyKeyspaceRoutingRules
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for 7f59799 - Browse repository at this point
Copy the full SHA 7f59799View commit details -
Merge remote-tracking branch 'planetscale/rohit/multi-tenant-routing-…
…rules-locking' into rohit/multi-tenant-routing-rules-locking Signed-off-by: Matt Lord <mattalord@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a696c1e - Browse repository at this point
Copy the full SHA a696c1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b08add - Browse repository at this point
Copy the full SHA 3b08addView commit details -
Another minor cleanup after merge + review
Signed-off-by: Matt Lord <mattalord@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0c84ec1 - Browse repository at this point
Copy the full SHA 0c84ec1View commit details
Commits on May 14, 2024
-
Try to deflake unit test when code coverage is enabled
Signed-off-by: Matt Lord <mattalord@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e65f861 - Browse repository at this point
Copy the full SHA e65f861View commit details -
Skip TestConcurrentKeyspaceRoutingRulesUpdates in code coverage mode
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Configuration menu - View commit details
-
Copy full SHA for c468c8d - Browse repository at this point
Copy the full SHA c468c8dView commit details