Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to all the contexts used for RPC calls in vtorc #15991

Merged
merged 2 commits into from
May 22, 2024

Merge remote-tracking branch 'upstream/main' into fix-vtorc-timeouts

acfcfc0
Select commit
Loading
Failed to load commit list.
Merged

Add timeout to all the contexts used for RPC calls in vtorc #15991

Merge remote-tracking branch 'upstream/main' into fix-vtorc-timeouts
acfcfc0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2024 in 1s

68.25% (-0.23%) compared to 3b09eb2

View this Pull Request on Codecov

68.25% (-0.23%) compared to 3b09eb2

Details

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 68.25%. Comparing base (3b09eb2) to head (acfcfc0).
Report is 3 commits behind head on main.

Files Patch % Lines
go/vt/vtorc/logic/tablet_discovery.go 0.00% 15 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15991      +/-   ##
==========================================
- Coverage   68.47%   68.25%   -0.23%     
==========================================
  Files        1562     1562              
  Lines      197083   197097      +14     
==========================================
- Hits       134962   134524     -438     
- Misses      62121    62573     +452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.