Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order by subquery planning #16049

Merged
merged 16 commits into from
Jun 12, 2024

Skip TestSubqueries if vtgate < 21

37ec476
Select commit
Loading
Failed to load commit list.
Merged

fix: order by subquery planning #16049

Skip TestSubqueries if vtgate < 21
37ec476
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 0s

68.22% (-0.01%) compared to 2531cd0, passed because coverage increased by +0.00% when compared to adjusted base (68.22%)

View this Pull Request on Codecov

68.22% (-0.01%) compared to 2531cd0, passed because coverage increased by +0.00% when compared to adjusted base (68.22%)

Details

Codecov Report

Attention: Patch coverage is 60.76555% with 82 lines in your changes missing coverage. Please review.

Project coverage is 68.22%. Comparing base (2531cd0) to head (37ec476).
Report is 7 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast.go 5.00% 38 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 58.97% 16 Missing ⚠️
go/vt/vtgate/planbuilder/operators/subquery.go 33.33% 10 Missing ⚠️
go/vt/vtgate/planbuilder/operators/aggregator.go 80.00% 5 Missing ⚠️
go/vt/vtgate/planbuilder/operators/projection.go 71.42% 4 Missing ⚠️
.../vtgate/planbuilder/operators/subquery_planning.go 80.95% 4 Missing ⚠️
.../vtgate/planbuilder/operators/horizon_expanding.go 88.46% 3 Missing ⚠️
go/vt/sqlparser/ast_funcs.go 80.00% 1 Missing ⚠️
...vtgate/planbuilder/operators/subquery_container.go 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16049      +/-   ##
==========================================
- Coverage   68.22%   68.22%   -0.01%     
==========================================
  Files        1543     1543              
  Lines      197586   197733     +147     
==========================================
+ Hits       134805   134903      +98     
- Misses      62781    62830      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov