Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new way of specifying test files to the vitess-tester #16233

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

frouioui
Copy link
Member

Description

This goes with vitessio/vt#9, it uses the new way of specifying the paths to the test files.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link
Contributor

vitess-bot bot commented Jun 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 19, 2024
@frouioui frouioui added Type: Internal Cleanup Component: Build/CI Backport to: release-20.0-rc Backport to: release-20.0 Needs to be backport to release-20.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 19, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 19, 2024
@shlomi-noach shlomi-noach mentioned this pull request Jun 20, 2024
34 tasks
@frouioui frouioui mentioned this pull request Jun 21, 2024
30 tasks
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.62%. Comparing base (f118ba2) to head (c4da927).
Report is 209 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16233      +/-   ##
==========================================
+ Coverage   68.40%   68.62%   +0.21%     
==========================================
  Files        1556     1544      -12     
  Lines      195121   197991    +2870     
==========================================
+ Hits       133479   135866    +2387     
- Misses      61642    62125     +483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit a3701e5 into vitessio:main Jun 25, 2024
94 checks passed
@systay systay deleted the update-vitess-tester-use branch June 25, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants