Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Fix Incorrect Optimization with LIMIT and GROUP BY (#16263) #16268

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 26, 2024

Description

This is a backport of #16263

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Contributor Author

vitess-bot bot commented Jun 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.0 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (15a66d5) to head (6a3f0cd).
Report is 3 commits behind head on release-20.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-20.0   #16268   +/-   ##
=============================================
  Coverage         68.60%   68.60%           
=============================================
  Files              1541     1541           
  Lines            197812   197814    +2     
=============================================
+ Hits             135702   135718   +16     
+ Misses            62110    62096   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
frouioui
frouioui previously approved these changes Jun 26, 2024
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge #16267 first for the upgrade/downgrade test.

Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the backport-16263-to-release-20.0 branch from d914e7f to d05f982 Compare June 26, 2024 17:13
@frouioui
Copy link
Member

I forced push the same commit again on this PR, for some reason the CI workflows were blocked in canceled

@frouioui frouioui dismissed their stale review June 26, 2024 20:07

Dismissing as the end-to-end test seems to be wrong.

@shlomi-noach shlomi-noach modified the milestones: v20.0.0, v20.0.1 Jun 27, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
@shlomi-noach shlomi-noach mentioned this pull request Jun 27, 2024
30 tasks
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 43ede26 into release-20.0 Jun 27, 2024
181 checks passed
@systay systay deleted the backport-16263-to-release-20.0 branch June 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants