-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup] Protos: Use UnmarshalPB() when unmarshalling a proto object #16311
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16311 +/- ##
=======================================
Coverage 68.72% 68.72%
=======================================
Files 1547 1547
Lines 198247 198247
=======================================
+ Hits 136238 136243 +5
+ Misses 62009 62004 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙏
Description
In #16096 we added
UnmarshalPB
for adding type safety while deserializing proto objects. That PR only updated the routing rules related code.In this PR we update move uses of
Unmarshal
over, which deserialize protos.Related Issue(s)
#16095
#16096
Checklist
Deployment Notes