Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement PERIOD_DIFF #16557

Merged
merged 1 commit into from
Aug 12, 2024

evalengine: Implement PERIOD_DIFF

73e392f
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement PERIOD_DIFF #16557

evalengine: Implement PERIOD_DIFF
73e392f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 7, 2024 in 0s

68.79% (+0.00%) compared to 0b7c0e4

View this Pull Request on Codecov

68.79% (+0.00%) compared to 0b7c0e4

Details

Codecov Report

Attention: Patch coverage is 89.23077% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (0b7c0e4) to head (73e392f).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/evalengine/fn_time.go 90.90% 3 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm.go 86.66% 2 Missing ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16557   +/-   ##
=======================================
  Coverage   68.78%   68.79%           
=======================================
  Files        1556     1556           
  Lines      199803   199868   +65     
=======================================
+ Hits       137429   137490   +61     
- Misses      62374    62378    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.