Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix slice init length #16674

Merged
merged 1 commit into from
Aug 28, 2024
Merged

bug: fix slice init length #16674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/trace/trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func StartTracing(serviceName string) io.Closer {
}

func fail(serviceName string) io.Closer {
options := make([]string, len(tracingBackendFactories))
options := make([]string, 0, len(tracingBackendFactories))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. The bug is that we are allocating a slice with empty strings and then appending to it, so we end up with a slice that is twice as long as it really needs to be. Another way of fixing it would have been to set the already allocated elements instead of appending to the slice, but this is cleaner.

for k := range tracingBackendFactories {
options = append(options, k)
}
Expand Down
Loading