-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTAdmin: Distributed transactions list on VTAdmin #16793
Conversation
…pace Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16793 +/- ##
==========================================
- Coverage 69.53% 69.51% -0.02%
==========================================
Files 1567 1568 +1
Lines 202388 202423 +35
==========================================
- Hits 140723 140708 -15
- Misses 61665 61715 +50 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
We should call it |
We should also display the age of the transaction to know from how long the transaction is unresolved. |
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
…ng UnresolvedTransactions Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
1401d9f
to
b1918eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we call for getting unresolved transactions for a keyspace.
There is a request parameter called abandonAge
.
We should use that and may be provide options to user to tell how old the transaction should be to display on VTAdmin.
5s
, 30s
, 5min
, etc.
This can also be done in a follow up PR. |
Description
TimeCreated
while querying unresolved transactionskeyspace
Sample output from API:
Related Issue(s)
Screenshots
Checklist
Deployment Notes