-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed Transaction: Action on commit prepared or redo prepared failure #16803
Open
harshit-gangal
wants to merge
7
commits into
vitessio:main
Choose a base branch
from
planetscale:tx-recovery-log-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+215
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Sep 18, 2024
harshit-gangal
added
Type: Feature Request
Component: Query Serving
and removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Sep 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16803 +/- ##
==========================================
+ Coverage 69.51% 69.54% +0.02%
==========================================
Files 1568 1568
Lines 202426 202450 +24
==========================================
+ Hits 140717 140785 +68
+ Misses 61709 61665 -44 ☔ View full report in Codecov by Sentry. |
harshit-gangal
removed
the
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
label
Sep 19, 2024
…store the error message Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
harshit-gangal
force-pushed
the
tx-recovery-log-state
branch
from
September 20, 2024 11:54
e1ed8ad
to
0d2b8ee
Compare
harshit-gangal
requested review from
systay,
shlomi-noach,
rohit-nayak-ps,
timvaillancourt,
deepthi and
GuptaManan100
as code owners
September 20, 2024 12:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR make changes to transaction recovery log state in resource managers.
On a commit prepared failure it checks if the error is retryable or not.
For a non-retryable error, the state is update to
FAILED
, error metric is updated and then they are are not prepared later.Same check happens on redo of prepared logs on a failure.
Once, the state is updated to
Failed
, a user intervention is needed to evaluate the root cause of the issue.This is a highly unlikely scenario and could have happened due to a bug in the system.
Related Issue(s)
Checklist