-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Temporarily skip flaky TestMoveTablesUnsharded #16812
Merged
frouioui
merged 1 commit into
vitessio:main
from
planetscale:rohit/temporarily-skip-TestMoveTablesUnsharded
Sep 20, 2024
Merged
CI: Temporarily skip flaky TestMoveTablesUnsharded #16812
frouioui
merged 1 commit into
vitessio:main
from
planetscale:rohit/temporarily-skip-TestMoveTablesUnsharded
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Sep 20, 2024
rohit-nayak-ps
added
Type: Testing
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16812 +/- ##
==========================================
- Coverage 69.53% 69.51% -0.02%
==========================================
Files 1568 1568
Lines 202423 202423
==========================================
- Hits 140747 140714 -33
- Misses 61676 61709 +33 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
requested review from
deepthi,
GuptaManan100 and
shlomi-noach
as code owners
September 20, 2024 10:59
harshit-gangal
approved these changes
Sep 20, 2024
frouioui
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The unit test
TestMoveTablesUnsharded
is increasingly flaky. Works locally everytime and also on a separate PR where I only enabled the unit test workflows, it didn't fail a few times I ran them. However on most PRs it seems to fail at least one of the tests (usually the 84 test, though that might be a coincidence).For now skipping the test until we fix the flakiness.
Related Issue(s)
Checklist
Deployment Notes