-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change upgrade test to still use the older version of tests #16937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 11, 2024
GuptaManan100
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Build/CI
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 11, 2024
Since we don't run Downgrade tests in main, I've created a PR against release-20.0 to see these changes work - #16938 |
It works as intended, since I can see in the test output for upgrade tests in #16938, we aren't running |
GuptaManan100
requested review from
deepthi,
frouioui,
mattlord and
rohit-nayak-ps
as code owners
October 11, 2024 09:28
frouioui
approved these changes
Oct 11, 2024
GuptaManan100
added
Backport to: release-18.0
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
labels
Oct 15, 2024
deepthi
approved these changes
Oct 15, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
vitess-bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
changed the title
Change upgrade test to still use the older verion of tests
Change upgrade test to still use the older version of tests
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Backport to: release-20.0
Needs to be backport to release-20.0
Backport to: release-21.0
Needs to be backport to release-21.0
Component: Build/CI
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the changes made to the upgrade tests in #16494. The situation has evolved as follows -
SkipIfBinaryBelowVersion
lines whenever we added a new feature, because the older binaries wouldn't support them, and downgrade tests would fail without them.SkipIf...
lines later.SkipIf..
lines because we're going to use the downgrade versions code for testing. And we won't run into the issue where a test passes in the original PR, but then fails when we create a different PR against v20.0, because when running upgrade tests in v20.0 we would still use the v20.0 code. This means that the upgrade tests from the previous release, and downgrade tests from the current release are symmetrical. So, if a test were to fail, it would fail on main.Related Issue(s)
Checklist
Deployment Notes