-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-21.0] [Direct PR] bugfix: add HAVING columns inside derived tables (#16976) #16980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
vitess-bot
bot
added
Backport
This is a backport
Component: Query Serving
Type: Bug
labels
Oct 16, 2024
vitess-bot
bot
requested review from
harshit-gangal,
systay,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
October 16, 2024 14:29
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
frouioui
approved these changes
Oct 16, 2024
systay
approved these changes
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-21.0 #16980 +/- ##
=============================================
Coverage 69.43% 69.44%
=============================================
Files 1570 1570
Lines 203841 203845 +4
=============================================
+ Hits 141547 141568 +21
+ Misses 62294 62277 -17 ☔ View full report in Codecov by Sentry. |
arthurschreiber
approved these changes
Oct 16, 2024
57 tasks
rohit-nayak-ps
changed the title
[release-21.0] bugfix: add HAVING columns inside derived tables (#16976)
[release-21.0] [DirectPR] bugfix: add HAVING columns inside derived tables (#16976)
Oct 17, 2024
rohit-nayak-ps
changed the title
[release-21.0] [DirectPR] bugfix: add HAVING columns inside derived tables (#16976)
[release-21.0] [Direct PR] bugfix: add HAVING columns inside derived tables (#16976)
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #16976