Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a per-file retry mechanism in the BuiltinBackupEngine #17271

Merged
merged 28 commits into from
Dec 9, 2024
Merged

Implement a per-file retry mechanism in the BuiltinBackupEngine #17271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8cffe83
wip
frouioui Nov 21, 2024
a98ada2
Implement retry logic for backing up the MANIFEST file
frouioui Nov 22, 2024
30badb6
Add a new test WriteCloser to test failing writes
frouioui Nov 22, 2024
ada41b7
Improve retry backup test and add new test
frouioui Nov 22, 2024
3875fd1
Remove flakiness in tests
frouioui Nov 22, 2024
7db26bc
Enhance support for restore and add more tests
frouioui Nov 25, 2024
48938fa
Fix context handling
frouioui Nov 26, 2024
c5bff6a
Refactor of the error recorder for backups
frouioui Nov 26, 2024
3c91e6f
Extract backup logic and implement proper retry
frouioui Nov 26, 2024
0e7f149
Improve retry logic when backing up the manifest
frouioui Nov 26, 2024
97ce557
Improve the retry logic for restores
frouioui Nov 26, 2024
af96d36
Fix minor issues with S3 and add mock implementation to test S3 backups
frouioui Nov 28, 2024
ad59e3f
Add local AWS S3 test
frouioui Nov 29, 2024
7b94451
Merge remote-tracking branch 'origin/main' into retry-failed-files-bu…
frouioui Nov 29, 2024
33d4e97
Add more AWS S3 tests for backup and restore
frouioui Nov 29, 2024
9514ea2
Create a flexible integration test with Minio
frouioui Nov 29, 2024
254ff48
Fix path to install Minio in GHA
frouioui Nov 29, 2024
cc02f31
Fix import fmt
frouioui Nov 29, 2024
514a4ea
Self-review
frouioui Nov 29, 2024
e7fd715
Make the S3 E2E test a proper cluster test
frouioui Nov 29, 2024
f1c37fa
Make the race detector happier
frouioui Nov 29, 2024
853c699
Make endpoint resolver optional
frouioui Dec 2, 2024
82d9baa
Avoid redundant file/folder name
frouioui Dec 2, 2024
8a35def
Apply review suggestions on the s3_builtin test
frouioui Dec 5, 2024
b006f4b
BackupHandle and s3_mock suggestions
frouioui Dec 5, 2024
19d6e28
Implement remaining review suggestions
frouioui Dec 5, 2024
25791d8
rename errorsbackup to errors
frouioui Dec 9, 2024
24935b2
make sure the entire backup ctx is canceled before inspecting the logs
frouioui Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/cluster_endtoend_21.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,13 @@ jobs:
# install JUnit report formatter
go install github.com/vitessio/go-junit-report@HEAD

- name: Install Minio
if: steps.skip-workflow.outputs.skip-workflow == 'false'
run: |
wget https://dl.min.io/server/minio/release/linux-amd64/minio
chmod +x minio
mv minio /usr/local/bin

- name: Setup launchable dependencies
if: steps.skip-workflow.outputs.is_draft == 'false' && steps.skip-workflow.outputs.skip-workflow == 'false' && steps.changes.outputs.end_to_end == 'true' && github.base_ref == 'main'
run: |
Expand Down
Loading
Loading