Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: move new consts to own section #17802

Merged
merged 1 commit into from
Feb 14, 2025
Merged

nit: move new consts to own section #17802

merged 1 commit into from
Feb 14, 2025

Conversation

timvaillancourt
Copy link
Contributor

Description

This PR fixes a minor nit introduced by my PR #17788

I didn't realize test/ci_workflow_gen.go had const/vars grouped by purpose, and I dumped my new consts in a group of const for MySQL versions. This PR moves the new consts to a new section

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
nit: move consts to own section
74ad404 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt self-assigned this Feb 14, 2025
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 14, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 14, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 14, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 14, 2025
@timvaillancourt timvaillancourt changed the title nit: move consts to own section nit: move new consts to own section Feb 14, 2025
@deepthi deepthi merged commit cf7fa68 into vitessio:main Feb 14, 2025
113 checks passed
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Feb 14, 2025
@timvaillancourt
nit: move new consts to own section (vitessio#17802)
10eeff3 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt mentioned this pull request Feb 16, 2025
Merged
5 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Feb 19, 2025
@timvaillancourt
slack-21.0: init v21 release (#600)
cf09832 
* `slack-21.0`: init v21 release

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* rm codecov workflow

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* add slackhq/vitess-addons token

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* use Cores16 logic in test/ci_workflow_gen.go

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* simplify

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Simply changing GH Actions runner (vitessio#17788)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix ci files

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* add comment

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* add private repo token

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix env

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* more private repo config

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* update templates

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* quote GOPRIVATE

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* nit: move new `const`s to own section (vitessio#17802)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* use runner `vitess-ubuntu24-16cpu-1`

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* dont make PAT token an env var

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add support for `GOPRIVATE` in CI templates

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* set `goPrivate`

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* empty commit to trigger ci

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* improve skip logic in TestSemiSyncUpgradeDowngrade

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix import

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees

@timvaillancourt timvaillancourt

Labels
Component: Build/CI Type: Internal Cleanup
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @deepthi @frouioui