Removing DemoteMaster from vtctl, and UI. #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-berlin will rebuild the UI and squash after approval. |
|
LGTM |
It is just a confusing command. The tabletmanager RPC command is still there (and used during reparent). But no need to expose it.
pivanof
added a commit
to pivanof/vitess
that referenced
this pull request
Nov 30, 2016
The site needed publishing after vitessio#2312 and maybe after some other changes. On the way I fixed a couple of incorrect things in vtctl docs (typo in an error message and change of tablet type name WORKER->DRAINED that happened in vitessio#2151).
pivanof
added a commit
that referenced
this pull request
Nov 30, 2016
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Patrick Reynolds <patrick@piki.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is just a confusing command. The tabletmanager RPC command is still
there (and used during reparent). But no need to expose it.