Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more mysql errno support #3087

Merged
merged 3 commits into from
Aug 18, 2017
Merged

more mysql errno support #3087

merged 3 commits into from
Aug 18, 2017

Conversation

bbeaudreault
Copy link
Contributor

@sougou we got a few more unbucketed errors in the last couple days so i went through and added a bunch more. This still isn't everything, but are the ones that looked obvious-ish.

@bbeaudreault
Copy link
Contributor Author

@sougou if you don't mind, I just changed the "disallowed outside transaction" error to Code_FAILED_PRECONDITION instead of Code_INVALID_ARGUMENT. I think the former makes more sense here, according to the docs:

// FAILED_PRECONDITION indicates operation was rejected because the
	// system is not in a state required for the operation's execution.
	// For example, directory to be deleted may be non-empty, an rmdir
	// operation is applied to a non-directory, etc.
	//
	// A litmus test that may help a service implementor in deciding
	// between FAILED_PRECONDITION, ABORTED, and UNAVAILABLE:
	//  (a) Use UNAVAILABLE if the client can retry just the failing call.
	//  (b) Use ABORTED if the client should retry at a higher-level
	//      (e.g., restarting a read-modify-write sequence).
	//  (c) Use FAILED_PRECONDITION if the client should not retry until
	//      the system state has been explicitly fixed.  E.g., if an "rmdir"
	//      fails because the directory is non-empty, FAILED_PRECONDITION
	//      should be returned since the client should not retry unless
	//      they have first fixed up the directory by deleting files from it.
	//  (d) Use FAILED_PRECONDITION if the client performs conditional
	//      REST Get/Update/Delete on a resource and the resource on the
	//      server does not match the condition. E.g., conflicting
	//      read-modify-write on the same resource.

@sougou
Copy link
Contributor

sougou commented Aug 18, 2017

Looks like endtoend test needs fixing.

PS: If I wait long enough, maybe you'll finish this project for me :)

@sougou
Copy link
Contributor

sougou commented Aug 18, 2017

LGTM

Approved with PullApprove

@sougou sougou merged commit 6e86173 into vitessio:master Aug 18, 2017
@bbeaudreault bbeaudreault deleted the mysql_errs branch August 18, 2017 16:31
@bbeaudreault bbeaudreault restored the mysql_errs branch September 5, 2017 21:10
frouioui pushed a commit to planetscale/vitess that referenced this pull request Nov 21, 2023
… add flag to specify that routing rules should not be created when a movetables workflow is created (vitessio#3088)

* backport of 3087

* Fix conflicts

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* make vtadmin proto

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants