Fixing binlog server panic. #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error occurs early in binlog streaming, we haven't started the streaming yet, so the close() method needs to check for this.
michael-berlin
approved these changes
Sep 27, 2017
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
* metrics: change vtbackup_duration_by_phase to binary-valued vtbackup_phase (vitessio#12973) Signed-off-by: Max Englander <max@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> * [CLI] cobra lots of things (vitessio#14007) Signed-off-by: Andrew Mason <andrew@planetscale.com> * go/cmd/vtbackup: wait for plugins to finish initializing (vitessio#14113) Signed-off-by: Max Englander <max@planetscale.com> --------- Signed-off-by: Max Englander <max@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Max Englander <max@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs early in binlog streaming, we haven't started the
streaming yet, so the close() method needs to check for this.
To fix #3253