[Sqlparser] VALUES(...) should take a fully-qualified column name #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More changes are needed. See the build failure :). |
|
Yep yep :) It's easier to punt these up here and have all the ci run than set it up locally :P |
danieltahara
force-pushed
the
insert-on-dup
branch
4 times, most recently
from
fed5fbb
to
58bb282
Compare
|
Added a negative test (mistmatched table name) and rebased. |
|
LGTM |
|
Bump :) |
|
The ETA on this is probably weekend. I'll try to find time before if possible. |
|
bump :) |
|
I've started working my way through. I should get to this soon enough now. |
sougou
reviewed
May 9, 2018
| if !node.Name.Qualifier.IsEmpty() && node.Name.Qualifier != ins.Table { | ||
| formatErr = vterrors.Errorf(vtrpcpb.Code_NOT_FOUND, | ||
| "could not find qualified column %v in table %v", | ||
| node.Name, ins.Table) |
There was a problem hiding this comment.
Use sqlparser.String(node.Name) instead. It will make the error more readable. Same for table name.
danieltahara
force-pushed
the
insert-on-dup
branch
from
58bb282
to
92e9dc0
Compare
|
@sougou - LGTM. @danieltahara - To make this change compatible with mine, I think you just need to change this: to: In: https://github.com/vitessio/vitess/blob/master/go/vt/vtgate/planbuilder/insert.go#L243 |
danieltahara
force-pushed
the
insert-on-dup
branch
from
92e9dc0
to
3a6fd4e
Compare
|
fixed. :) |
A values expression is allowed to take a fully qualified (table.col), but the current parser only allows unqualified columns. I have modified the grammar, plan builder, and AST accordingly. Signed-off-by: Daniel Tahara <tahara@dropbox.com>
danieltahara
force-pushed
the
insert-on-dup
branch
from
3a6fd4e
to
98e162a
Compare
sougou
approved these changes
May 11, 2018
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 12, 2024
…n VPlayer: support statement and transaction batching (vitessio#3883) * cherry pick of 14502 (vitessio#3881) Signed-off-by: Matt Lord <mattalord@gmail.com> * Corrections Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A values expression is allowed to take a fully qualified (table.col), but the current parser only allows unqualified columns. I have modified the grammar, plan builder, and AST accordingly.
Signed-off-by: Daniel Tahara tahara@dropbox.com